Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

[#9922] Enhanced resource reclaimation in hbase2 client #9933

Merged
merged 1 commit into from
May 16, 2023

Conversation

smilu97
Copy link
Contributor

@smilu97 smilu97 commented May 12, 2023

resolves #9922

Changes

  • Explicitly closes HTableMultiplexer
  • Explicitly shutdown HTableFlushWorkers
  • Explicitly shutdown netty idle connection sweeper
  • Explicitly closes netty wheel timer
  • Explicitly shutdown netty event-loop-group
  • Explicitly finalizes direct buffer arenas of netty
  • Nullify flink-bootstrap after closing
  • Do reachable-test when choosing ip
  • Fixed wrong dependencies (hbase-shaded-client)

@smilu97 smilu97 self-assigned this May 12, 2023
@codecov
Copy link

codecov bot commented May 12, 2023

Codecov Report

Merging #9933 (5f0bd62) into master (ed4e8a4) will decrease coverage by 0.05%.
The diff coverage is 2.89%.

@@             Coverage Diff              @@
##             master    #9933      +/-   ##
============================================
- Coverage     38.85%   38.80%   -0.05%     
+ Complexity    11907    11875      -32     
============================================
  Files          3538     3536       -2     
  Lines         93995    93888     -107     
  Branches      10496    10478      -18     
============================================
- Hits          36520    36433      -87     
+ Misses        54304    54294      -10     
+ Partials       3171     3161      -10     
Impacted Files Coverage Δ
...p/pinpoint/common/hbase/ConnectionFactoryBean.java 0.00% <0.00%> (ø)
...point/common/hbase/HBaseAsyncOperationFactory.java 0.00% <0.00%> (ø)
...t/common/hbase/TableMultiplexerAsyncOperation.java 0.00% <0.00%> (ø)
...n/java/com/navercorp/pinpoint/flink/Bootstrap.java 0.00% <0.00%> (ø)
...rp/pinpoint/flink/cluster/FlinkServerRegister.java 0.00% <0.00%> (ø)
...orp/pinpoint/flink/receiver/TcpSourceFunction.java 0.00% <0.00%> (ø)
...mon/server/bo/stat/join/JoinApplicationStatBo.java 86.66% <100.00%> (ø)

... and 34 files with indirect coverage changes

@smilu97 smilu97 force-pushed the 9922_flink branch 4 times, most recently from af7b0bb to 32bb41d Compare May 16, 2023 01:56
Copy link
Member

@minwoo-jung minwoo-jung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good!

@smilu97 smilu97 merged commit 0f1673f into pinpoint-apm:master May 16, 2023
@smilu97 smilu97 deleted the 9922_flink branch May 16, 2023 08:36
# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Flink in hbase2-module does not work, reclaim resources
2 participants