FinalNewlineRule: don't report for empty files

pinterest · May 13, 2020 · 63a7432 · 63a7432
1 parent cb0595b
commit 63a7432
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 5 deletions.
diff --git a/...uleset-standard/src/main/kotlin/com/pinterest/ktlint/ruleset/standard/FinalNewlineRule.kt b/...uleset-standard/src/main/kotlin/com/pinterest/ktlint/ruleset/standard/FinalNewlineRule.kt
@@ -15,6 +15,7 @@ class FinalNewlineRule : Rule("final-newline"), Rule.Modifier.RestrictToRoot {
         emit: (offset: Int, errorMessage: String, canBeAutoCorrected: Boolean) -> Unit
     ) {
         if (node.isRoot()) {
+            if (node.textLength == 0) return
             val editorConfig = node.getUserData(KtLint.EDITOR_CONFIG_USER_DATA_KEY)!!
             val insertFinalNewline = editorConfig.insertFinalNewline
             val lastNode = lastChildNodeOf(node)

diff --git a/...et-standard/src/test/kotlin/com/pinterest/ktlint/ruleset/standard/FinalNewlineRuleTest.kt b/...et-standard/src/test/kotlin/com/pinterest/ktlint/ruleset/standard/FinalNewlineRuleTest.kt
@@ -23,11 +23,7 @@ class FinalNewlineRuleTest {
                 "",
                 mapOf("insert_final_newline" to "true")
             )
-        ).isEqualTo(
-            listOf(
-                LintError(1, 1, "final-newline", "File must end with a newline (\\n)")
-            )
-        )
+        ).isEmpty()
         assertThat(
             FinalNewlineRule().lint(
                 "fun name() {\n}",
@@ -52,6 +48,12 @@ class FinalNewlineRuleTest {
             )
         ).isEmpty()
         // false
+        assertThat(
+            FinalNewlineRule().lint(
+                "",
+                mapOf("insert_final_newline" to "false")
+            )
+        ).isEmpty()
         assertThat(
             FinalNewlineRule().lint(
                 "fun name() {\n}",