Fix false positive when primary constructor has no arguments and a se…

…condary constructor exists (#2717) Closes #2690
pinterest · Jun 26, 2024 · 6f0a313 · 6f0a313
1 parent 5fb8373
commit 6f0a313
Show file tree

Hide file tree

Showing 2 changed files with 27 additions and 0 deletions.
diff --git a/...tandard/src/main/kotlin/com/pinterest/ktlint/ruleset/standard/rules/ClassSignatureRule.kt b/...tandard/src/main/kotlin/com/pinterest/ktlint/ruleset/standard/rules/ClassSignatureRule.kt
@@ -1,6 +1,7 @@
 package com.pinterest.ktlint.ruleset.standard.rules
 
 import com.pinterest.ktlint.rule.engine.core.api.AutocorrectDecision
+import com.pinterest.ktlint.rule.engine.core.api.ElementType
 import com.pinterest.ktlint.rule.engine.core.api.ElementType.ANNOTATION
 import com.pinterest.ktlint.rule.engine.core.api.ElementType.ANNOTATION_ENTRY
 import com.pinterest.ktlint.rule.engine.core.api.ElementType.CLASS
@@ -273,6 +274,19 @@ public class ClassSignatureRule :
                 // Allow:
                 //     class Foo constructor() { ... }
                 it.prevCodeSibling()?.elementType == CONSTRUCTOR_KEYWORD
+            }?.takeUnless {
+                // Allow
+                //     class Foo() {
+                //         constructor(foo: String): this() {
+                //             println(foo)
+                //         }
+                //     }
+                node
+                    .findChildByType(CLASS_BODY)
+                    ?.findChildByType(ElementType.SECONDARY_CONSTRUCTOR)
+                    ?.findChildByType(ElementType.CONSTRUCTOR_DELEGATION_CALL)
+                    ?.firstChildNode
+                    ?.elementType == ElementType.CONSTRUCTOR_DELEGATION_REFERENCE
             }?.let { parameterList ->
                 if (!dryRun) {
                     emit(parameterList.startOffset, "No parenthesis expected", true)

diff --git a/...ard/src/test/kotlin/com/pinterest/ktlint/ruleset/standard/rules/ClassSignatureRuleTest.kt b/...ard/src/test/kotlin/com/pinterest/ktlint/ruleset/standard/rules/ClassSignatureRuleTest.kt
@@ -1835,6 +1835,19 @@ class ClassSignatureRuleTest {
         }
     }
 
+    @Test
+    fun `Issue 2690 - Given an empty primary constructor and secondary constructor with delegation reference`() {
+        val code =
+            """
+            class Foo() {
+                constructor(foo: String) : this() {
+                    // N/A
+                }
+            }
+            """.trimIndent()
+        classSignatureWrappingRuleAssertThat(code).hasNoLintViolations()
+    }
+
     private companion object {
         const val UNEXPECTED_SPACES = "  "
         const val NO_SPACE = ""