-
Notifications
You must be signed in to change notification settings - Fork 506
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
ArgumentListWrapping reports false positive since 0.41.0 #1159
Comments
I have solved issue's like this in PR #1052 which is still waiting to be merged. |
Thanks! However i've just built your branch and my case above still produced the false positives. |
Sorry for miscommunication. The PR mentioned above is the first PR of a range of 5 PR's. Originally I submitted one big PR resolving many identation issues. On request of maintainers I have split it into multiple smaller PR's. The other PR's can only be submitted once the first is merged. |
Looks like it was introduced in this commit: 3591e61 |
…ression without assignment Fixes pinterest#1159
…sion without assignment Fixes pinterest#1159
* Revert "Fix false positive when argument list is after multiline dot-qualified expression (pinterest#1025)" This reverts commit 3591e61. * Fix regression with argument-list-wrapping after dot qualified expression without assignment Fixes pinterest#1159
Messed with this issue again on 0.42.1 fun onSendMessageClicked() {
flow { chat.sendMessage(state.messageInput) }
.onEach { state ->
updateState(
messageIsSending = state.isLoading, // <-- ArgumentListWrapping
messageInput = "", // <-- ArgumentListWrapping
) // <-- ArgumentListWrapping
}
.launchIn(coroutineScope)
} |
@osipxd You commented a closed issue. Also it is not clear what the problem or your expectation is. Maybe it is better to open a new issue? |
Sorry, it was due to old ktlint version |
I have the following code snippet:
Expected Behavior
Ktlint should not report any issues
Observed Behavior
Since Ktlint 0.41.0, the
ArgumentListWrappingRule
reports the following:It means it tells this would be correct:
Steps to Reproduce
Run
ktlint codesnippet.kt --android --experimental
Your Environment
The text was updated successfully, but these errors were encountered: