Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Add testing on Java 20 and remove testing for Java 19 #1888

Closed
paul-dingemans opened this issue Mar 25, 2023 · 0 comments · Fixed by #2120
Closed

Add testing on Java 20 and remove testing for Java 19 #1888

paul-dingemans opened this issue Mar 25, 2023 · 0 comments · Fixed by #2120
Milestone

Comments

@paul-dingemans
Copy link
Collaborator

Java 19 has reached end of life per March 21st, 2023. Java 20 has been release on that date. As of that, testing on Java 19 has to be replaced with testing on Java 20.

mateuszkwiecinski pushed a commit to mateuszkwiecinski/ktlint that referenced this issue Jul 9, 2023
@paul-dingemans paul-dingemans added this to the 1.0 (Yeah!) milestone Jul 13, 2023
mateuszkwiecinski pushed a commit to mateuszkwiecinski/ktlint that referenced this issue Jul 15, 2023
mateuszkwiecinski pushed a commit to mateuszkwiecinski/ktlint that referenced this issue Jul 16, 2023
mateuszkwiecinski pushed a commit to mateuszkwiecinski/ktlint that referenced this issue Jul 16, 2023
mateuszkwiecinski pushed a commit to mateuszkwiecinski/ktlint that referenced this issue Jul 16, 2023
mateuszkwiecinski pushed a commit to mateuszkwiecinski/ktlint that referenced this issue Jul 16, 2023
mateuszkwiecinski pushed a commit to mateuszkwiecinski/ktlint that referenced this issue Jul 26, 2023
mateuszkwiecinski pushed a commit to mateuszkwiecinski/ktlint that referenced this issue Jul 28, 2023
paul-dingemans added a commit that referenced this issue Jul 31, 2023
…ous Java versions (#2120)

* Replace testing on java 19 with testing on java 20

Closes #1888

* Unify `yml` files formating

* Do NOT compile the project with various Java version, instead test agains various java verstions

https://jakewharton.com/build-on-latest-java-test-through-lowest-java/

* Add `-add-opens` jvmArg to prevent ignored warnings

* Migrate away deprecated `java.net.URL` constructor

* Setup toolchain resolver

If someone doesn't have required java installed Gradle will attempt to install one

* Extract common build setup + fix memory settings

The build needs less than 0.5GB of a java heap memory. There is no value in reserving more than half of available RAM just for the Gradle demon. It's better to keep Gradle daemon small  and leave the memory available to other forked processes (i.e. tests)

* Disable VFS on CI

CI doesn't modify files, there is no value in putting extra effort in efficiently tracking changed files. From test runs VFS comes with noticable performance impact on Windows build

* Update comment with extra clarification

* Disable automatic build scans publishing on local builds

* Update kotlin dev version

* Fix `-PkotlinDev` not running tests agains configured kotlin version

* Fix `-PkotlinDev` artifacts version

* Run `-PkotlinDev` build as a separate workflow job in parallel

Co-authored-by: paul-dingemans <paul-dingemans@users.noreply.github.com>
paul-dingemans added a commit to oshai/ktlint that referenced this issue Jul 31, 2023
…ous Java versions (pinterest#2120)

* Replace testing on java 19 with testing on java 20

Closes pinterest#1888

* Unify `yml` files formating

* Do NOT compile the project with various Java version, instead test agains various java verstions

https://jakewharton.com/build-on-latest-java-test-through-lowest-java/

* Add `-add-opens` jvmArg to prevent ignored warnings

* Migrate away deprecated `java.net.URL` constructor

* Setup toolchain resolver

If someone doesn't have required java installed Gradle will attempt to install one

* Extract common build setup + fix memory settings

The build needs less than 0.5GB of a java heap memory. There is no value in reserving more than half of available RAM just for the Gradle demon. It's better to keep Gradle daemon small  and leave the memory available to other forked processes (i.e. tests)

* Disable VFS on CI

CI doesn't modify files, there is no value in putting extra effort in efficiently tracking changed files. From test runs VFS comes with noticable performance impact on Windows build

* Update comment with extra clarification

* Disable automatic build scans publishing on local builds

* Update kotlin dev version

* Fix `-PkotlinDev` not running tests agains configured kotlin version

* Fix `-PkotlinDev` artifacts version

* Run `-PkotlinDev` build as a separate workflow job in parallel

Co-authored-by: paul-dingemans <paul-dingemans@users.noreply.github.com>
paul-dingemans added a commit to oshai/ktlint that referenced this issue Jul 31, 2023
…ous Java versions (pinterest#2120)

* Replace testing on java 19 with testing on java 20

Closes pinterest#1888

* Unify `yml` files formating

* Do NOT compile the project with various Java version, instead test agains various java verstions

https://jakewharton.com/build-on-latest-java-test-through-lowest-java/

* Add `-add-opens` jvmArg to prevent ignored warnings

* Migrate away deprecated `java.net.URL` constructor

* Setup toolchain resolver

If someone doesn't have required java installed Gradle will attempt to install one

* Extract common build setup + fix memory settings

The build needs less than 0.5GB of a java heap memory. There is no value in reserving more than half of available RAM just for the Gradle demon. It's better to keep Gradle daemon small  and leave the memory available to other forked processes (i.e. tests)

* Disable VFS on CI

CI doesn't modify files, there is no value in putting extra effort in efficiently tracking changed files. From test runs VFS comes with noticable performance impact on Windows build

* Update comment with extra clarification

* Disable automatic build scans publishing on local builds

* Update kotlin dev version

* Fix `-PkotlinDev` not running tests agains configured kotlin version

* Fix `-PkotlinDev` artifacts version

* Run `-PkotlinDev` build as a separate workflow job in parallel

Co-authored-by: paul-dingemans <paul-dingemans@users.noreply.github.com>
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
1 participant