Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Remove chain-method-continuation dependency on argument-list-wrapping #2452

Closed
mklnwt opened this issue Dec 20, 2023 · 1 comment · Fixed by #2468
Closed

Remove chain-method-continuation dependency on argument-list-wrapping #2452

mklnwt opened this issue Dec 20, 2023 · 1 comment · Fixed by #2468
Labels
chain-method-continuation rule
Milestone
1.1.1

Comments

@mklnwt
Copy link

mklnwt commented Dec 20, 2023

Disabling the argument-list-wrapping rules forces users to disable chain-method-continution as well.

chain-method-continution should run before, but independently of argument-list-wrapping.

Additional information

  • Current version of ktlint: 1.1.0
@paul-dingemans
Copy link
Collaborator

At first glance it seems possible to soften the requirement that the argument-list-wrapping must be loaded and enabled. But it it is loaded then the dependency will stil require the argument-list-wrapping to run before chain-method-continuation (see #2445).

@paul-dingemans paul-dingemans added this to the 1.1.1 milestone Dec 21, 2023
@paul-dingemans paul-dingemans changed the title Remove chain-method-continution dependency on argument-list-wrapping Remove chain-method-continuation dependency on argument-list-wrapping Dec 27, 2023
paul-dingemans added a commit that referenced this issue Dec 27, 2023
@paul-dingemans
Loosen dependency between chain-method-continuation and argument-list…
0934f37 
…-wrapping

Allow the chain-method-continuation rule to be run when argument-list-wrapping is disabled or not loaded. Whenever both rules are loaded, the argument-list-wrapping takes precedence and runs before the chain-method-continuation.

Closes #2452
paul-dingemans added a commit that referenced this issue Dec 27, 2023
@paul-dingemans
Loosen dependency between chain-method-continuation and argument-list…
6b6485b 
…-wrapping

Allow the chain-method-continuation rule to be run when argument-list-wrapping is disabled or not loaded. Whenever both rules are loaded, the argument-list-wrapping takes precedence and runs before the chain-method-continuation.

Closes #2452
@paul-dingemans paul-dingemans mentioned this issue Dec 27, 2023
Merged
8 tasks
paul-dingemans added a commit that referenced this issue Dec 29, 2023
@paul-dingemans
Loosen dependency between chain-method-continuation and argument-list…
b3c9277 
…-wrapping (#2468)

* Loosen dependency between chain-method-continuation and argument-list-wrapping

Allow the chain-method-continuation rule to be run when argument-list-wrapping is disabled or not loaded. Whenever both rules are loaded, the argument-list-wrapping takes precedence and runs before the chain-method-continuation.

Closes #2452
paul-dingemans added a commit to Goooler/ktlint that referenced this issue Jan 2, 2024
@paul-dingemans
Loosen dependency between chain-method-continuation and argument-list…
736e4ab 
…-wrapping (pinterest#2468)

* Loosen dependency between chain-method-continuation and argument-list-wrapping

Allow the chain-method-continuation rule to be run when argument-list-wrapping is disabled or not loaded. Whenever both rules are loaded, the argument-list-wrapping takes precedence and runs before the chain-method-continuation.

Closes pinterest#2452
# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees
No one assigned
Labels
chain-method-continuation rule
Projects
None yet
Milestone
1.1.1
Development

Successfully merging a pull request may close this issue.

Loosen dependency between chain-method-continuation and argument-list-wrapping pinterest/ktlint
2 participants
@paul-dingemans @mklnwt