Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Indentation rule is incomplete #338

Closed
shyiko opened this issue Feb 11, 2019 · 5 comments
Closed

Indentation rule is incomplete #338

shyiko opened this issue Feb 11, 2019 · 5 comments

Comments

@shyiko
Copy link
Collaborator

shyiko commented Feb 11, 2019

IndentationRule is too basic. All it does is check that indentation is a multiple of indent_size. We need to rewrite the rule to calculate & adjust the indentation in a single pass over AST.

Related Issues: #141 #285 #294 (PR; came close but appears to be abandoned) #296 #324

@shyiko
Copy link
Collaborator Author

shyiko commented Mar 11, 2019

0.31.0

@gnomeria
Copy link

Is it still experimental in 0.35 ? Somehow I couldn't autoformat any indentation rules

@kozaxinan
Copy link

New experimental indentation rule still doesn't check continuation_indent_size. Is that intended? It would be nice to have indent_size = 2 and continuation_indent_size = 4. It is not possible at the moment. Is there any plan to support different continuation_indent_size?

@Tapchicoma
Copy link
Collaborator

@kozaxinan I would propose to open a separate issue for your problem

@pinterest pinterest locked as resolved and limited conversation to collaborators May 25, 2020
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants