Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Fix indentation of secondary constructor #1304

Merged
merged 3 commits into from
Dec 14, 2021
Merged

Fix indentation of secondary constructor #1304

merged 3 commits into from
Dec 14, 2021

Conversation

paul-dingemans
Copy link
Collaborator

Description

Fix indentation of secondary constructor

The call to super needs an additional indent compared to other situation in which a colon is found. Resulting code now looks like:

class Issue1222 {
    constructor(string1: String, string2: String2) :
            super(
                string1, string2
            ) {
        // do something
    }
}

Closes #1222

Checklist

  • tests are added
  • CHANGELOG.md is updated

Paul Dingemans added 2 commits December 13, 2021 20:14
Remove support of continuation index in secondary constructor
d8179bb 
This aligns the formatting with the default IntelliJ formatting of secondary
constructors.

Closes pinterest#1222
Merge branch 'master' into 1222-indent-seconday-constructor
640f3c3 
# Conflicts:
#	CHANGELOG.md
@romtsn romtsn merged commit 47b9f34 into pinterest:master Dec 14, 2021
@paul-dingemans paul-dingemans deleted the 1222-indent-seconday-constructor branch February 5, 2022 11:16
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@romtsn romtsn romtsn approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Code indents are according to Super call instead of to the main constructor block
2 participants
@paul-dingemans @romtsn