Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Use JVM_CONFIG_FILES instead of EMPTY #132

Merged
merged 1 commit into from
Dec 27, 2017

Conversation

MyDogTom
Copy link
Contributor

Because EnvironmentConfigFiles.EMPTY is removed in 1.2.20
This is copy-paste of the similar change from Kotlin itself
JetBrains/kotlin@afc9d3e#diff-0326941c85afd979faa6998b7b95bff8R55

fixes #131

Commit message from kotlin repository says

Drop EnvironmentConfigFiles.EMPTY and replace its only usage in
preprocessor with JVM_CONFIG_FILES: it's easier and won't affect
anything

Unfortunately, I have no idea if the same reasoning applies to KtLint or not. My feeling says yes, because KtLint and Preprocessor classes look very very similar.

…figFiles.EMPTY

Because EMPTY is removed in 1.2.20
This is copy-paste of similar changes from Kotlin itself
JetBrains/kotlin@afc9d3e#diff-0326941c85afd979faa6998b7b95bff8R55

fixes pinterest#131
@jeremymailen
Copy link
Contributor

Thank you for looking into this!

@shyiko
Copy link
Collaborator

shyiko commented Dec 27, 2017

Thank you, @MyDogTom!

@shyiko shyiko merged commit fbfcbe8 into pinterest:master Dec 27, 2017
@MyDogTom MyDogTom mentioned this pull request Jan 17, 2018
shyiko added a commit that referenced this pull request Jan 18, 2018
JelloRanger pushed a commit to JelloRanger/ktlint that referenced this pull request Apr 8, 2018
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ktlint not compatible with kotlin 1.2.20-eap-11
3 participants