use sed entirely with regex to get the java major version

[rawilder]

Description

Fix java version being incorrectly set when JAVA_TOOL_OPTIONS has a value. It being set causes unexpected output for the current java version parsing method.

Investigation

This seems to be happening from these two lines in the ktlint start

# incorrectly retrieves version
JV=$(java -version 2>&1 | head -1 | cut -d'"' -f2 | sed '/^1\./s///' | cut -d'.' -f1)
echo $JV
# echoes 'Picked up JAVA_TOOL_OPTIONS:'
X=$( [ "$JV" -ge "16" ] && echo "--add-opens java.base/java.lang=ALL-UNNAMED" || echo "")
# this command fails because the version is not correctly parsed

Ktlint still runs okay, it just spits some errors in the beginning. This could be solved with a different way to get the java version. Perhaps something with sed or awk to search for the 'version' string instead of head.

Local test results

A couple of tests failed locally but the same tests failed on master for me locally.

CLI basic checks > Given CLI argument --help then return the help output() FAILED
    org.opentest4j.AssertionFailedError at SimpleCLITest.kt:14

CLI basic checks > Given CLI argument --version then return the version information output() FAILED
    org.opentest4j.AssertionFailedError at SimpleCLITest.kt:29

CLI basic checks > Given some code without errors then return from lint with normal exit code and no error output() FAILED
    org.opentest4j.AssertionFailedError at SimpleCLITest.kt:45

Closes #1543

Checklist

• PR description added
• tests are added // is this something I can test considering it is in the build execution itself?
• CHANGELOG.md is updated

[paul-dingemans]

I am just reading the issue #1543 after making my review remarks. That issue clarifies already a lot.

[rawilder]

Would you like me to update the PR description with text from the issue to make it clearer what this is doing?

[paul-dingemans]

Would you like me to update the PR description with text from the issue to make it clearer what this is doing?

That would have helped with the initial review. It would be great if you can still update it though for future reference.

[rawilder]

Updated description with more info.