Enforce trailing commas at call site by default #1670
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The Kotlin Coding Conventions says re: trailing commas:
However it also says:
This suggests only benefits but no downsides (other than personal taste) to enforcing the use of trailing commas by default.
ktlint currently enforces no commas at call sites by default, which is opinionated in a way that conflicts with this guidance and the rationale for using trailing commas in all cases.
Checklist
CHANGELOG.md
is updatedIn case of adding a new rule: