Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Fix bug in parseImportsLayout: trim spaces in entries #1770

Merged

Conversation

jonasfa
Copy link
Contributor

@jonasfa jonasfa commented Jan 10, 2023

Description

This MR fixes a typo in parseImportsLayout(String) that causes the .editorconfig property ij_kotlin_imports_layout to be parsed incorrectly when it contains spaces after commas (e.g. *, ^). This issue is particularly annoying given IntelliJ adds spaces by default when its "Reformat Code" action is used.

Checklist

  • PR description added
  • tests are added
  • KtLint has been applied on source code itself and violations are fixed
  • documentation is updated
  • CHANGELOG.md is updated

@jonasfa jonasfa force-pushed the parseImportsLayout_trim_spaces branch from 9cb26aa to f12ab85 Compare January 10, 2023 18:47
@jonasfa jonasfa changed the title Fix typo in parseImportsLayout: trim spaces in entries Fix bug in parseImportsLayout: trim spaces in entries Jan 11, 2023
@paul-dingemans
Copy link
Collaborator

Tnx. I will have a look next week.

@paul-dingemans paul-dingemans merged commit 3eb37b5 into pinterest:master Jan 16, 2023
@paul-dingemans paul-dingemans added this to the 0.48.2 milestone Jan 16, 2023
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants