Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Add documents about trailing comma is disabled when wrapping is enabled #1800

Merged
merged 5 commits into from
Feb 1, 2023

Conversation

sanggggg
Copy link
Contributor

@sanggggg sanggggg commented Jan 30, 2023

Description

From Kotlin Slack

If wrapping rule is disabled then trailing comma on call site & trailing comma on declaration site is disabled, because w/o wrapping trailing commas can produce weird formattings. (see 10cb29c)

But there are no descriptions in rule documents about existence of this dependency and why exists. It may confuse users, so I added it.

Checklist

  • PR description added
  • tests are added
  • KtLint has been applied on source code itself and violations are fixed
  • documentation is updated
  • CHANGELOG.md is updated

In case of adding a new rule:

Copy link
Collaborator

@paul-dingemans paul-dingemans left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tnx for improvement. I have improved it further. I first tried to explain it in review comments, but that turned out more difficult than actually changing it ;-)

I will push my changes and wait for your review of my changes.

docs/rules/standard.md Show resolved Hide resolved
docs/rules/standard.md Outdated Show resolved Hide resolved
docs/rules/standard.md Outdated Show resolved Hide resolved
docs/rules/standard.md Outdated Show resolved Hide resolved
docs/rules/standard.md Outdated Show resolved Hide resolved
docs/rules/standard.md Show resolved Hide resolved
@sanggggg
Copy link
Contributor Author

Thanks for your kind reviews about PR, I've answered and fixed some changes about your comments.

Copy link
Contributor Author

@sanggggg sanggggg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! 🚀

@paul-dingemans paul-dingemans merged commit d51de4c into pinterest:master Feb 1, 2023
@paul-dingemans
Copy link
Collaborator

Looks good to me! 🚀

Thanks for collaboration!

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants