-
Notifications
You must be signed in to change notification settings - Fork 509
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Add documents about trailing comma is disabled when wrapping is enabled #1800
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tnx for improvement. I have improved it further. I first tried to explain it in review comments, but that turned out more difficult than actually changing it ;-)
I will push my changes and wait for your review of my changes.
Thanks for your kind reviews about PR, I've answered and fixed some changes about your comments. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me! 🚀
Thanks for collaboration! |
Description
From Kotlin Slack
If wrapping rule is disabled then trailing comma on call site & trailing comma on declaration site is disabled, because w/o wrapping trailing commas can produce weird formattings. (see 10cb29c)
But there are no descriptions in rule documents about existence of this dependency and why exists. It may confuse users, so I added it.
Checklist
CHANGELOG.md
is updatedIn case of adding a new rule: