Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Clean up logging dependencies #1999

Merged
merged 2 commits into from
May 7, 2023
Merged

Clean up logging dependencies #1999

merged 2 commits into from
May 7, 2023

Conversation

paul-dingemans
Copy link
Collaborator

Description

Clean up unwanted dependencies below:

  • ktlint-ruleset-standard has an unneeded implementation dependency on io.github.microutils:kotlin-logging-jvm:3.0.5 and ktlint-rule-engine has a testImplementation dependency on ktlint-ruleset-standard.
  • ktlint-test has an api dependency on logback which is only needed for a unit test. The ktlint-rule-engine has a test implementation dependency on ktlint-test.

Closes #1998

Checklist

  • PR description added
  • tests are added
  • KtLint has been applied on source code itself and violations are fixed
  • documentation is updated
  • CHANGELOG.md is updated

In case of adding a new rule:

@paul-dingemans paul-dingemans merged commit 6500181 into master May 7, 2023
@paul-dingemans paul-dingemans deleted the 1998-clean-up-logging-dependencies branch May 7, 2023 18:18
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Clean up logging dependencies
1 participant
@paul-dingemans