Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Do not remove parenthesis after explicit class constructor without arguments #2226

Merged
merged 2 commits into from
Sep 4, 2023

Conversation

paul-dingemans
Copy link
Collaborator

@paul-dingemans paul-dingemans commented Sep 4, 2023

Description

Given a class with an explicit constructor not having arguments:

class Foo constructor() {
    fun bar()
}

should not result in removal of the parenthesis after constructor as it results in a compilation error.

Checklist

Before submitting the PR, please check following (checks which are not relevant may be ignored):

  • Commit message are well written. In addition to a short title, the commit message also explain why a change is made.
  • At least one commit message contains a reference Closes #<xxx> or Fixes #<xxx> (replace<xxx> with issue number)
  • Tests are added
  • KtLint format has been applied on source code itself and violations are fixed
  • CHANGELOG.md is updated
  • PR description added

Documentation is updated. See difference between snapshot and release documentation

@paul-dingemans paul-dingemans added this to the 1.0 (Yeah!) milestone Sep 4, 2023
@paul-dingemans paul-dingemans merged commit 0bab9b8 into master Sep 4, 2023
@paul-dingemans paul-dingemans deleted the fix-empty-constructor branch September 4, 2023 17:54
# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant