Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Fix code style parameter in cli #2241

Merged
merged 4 commits into from
Sep 7, 2023

Conversation

paul-dingemans
Copy link
Collaborator

@paul-dingemans paul-dingemans commented Sep 5, 2023

Description

Pass parameter --code-style correctly to KtlintRuleEngine if value other than android_studio.

Closes #2238

Also, deprecate parameters '--code-style', '--disabled-rules' and '--experimental' as those should be specified in the '.editorconfig' properties

Checklist

Before submitting the PR, please check following (checks which are not relevant may be ignored):

  • Commit message are well written. In addition to a short title, the commit message also explain why a change is made.
  • At least one commit message contains a reference Closes #<xxx> or Fixes #<xxx> (replace<xxx> with issue number)
  • Tests are added
  • KtLint format has been applied on source code itself and violations are fixed
  • CHANGELOG.md is updated
  • PR description added

Documentation is updated. See difference between snapshot and release documentation

Pass parameter correctly to KtlintRuleEngine.
Also, deprecate parameters '--code-style', '--disabled-rules' and '--experimental' as those should be specified in the '.editorconfig' properties
@paul-dingemans paul-dingemans added this to the 1.0.1 milestone Sep 5, 2023
@paul-dingemans paul-dingemans merged commit 85ef029 into master Sep 7, 2023
@paul-dingemans paul-dingemans deleted the 2238-fix-code-style-parameter-in-cli branch September 7, 2023 16:21
# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ktlint-cli --code-style=intellij_idea is not respected in ktlint 1.0.0
1 participant