Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Improve checking on backing property #2346

Merged
merged 1 commit into from
Nov 15, 2023

Conversation

paul-dingemans
Copy link
Collaborator

Description

Improve checking on backing property

  • Provide better message when the backing property does not have a private modifier
  • Check that property correlated with the backing property is public

Closes #2345

Checklist

Before submitting the PR, please check following (checks which are not relevant may be ignored):

  • Commit message are well written. In addition to a short title, the commit message also explain why a change is made.
  • At least one commit message contains a reference Closes #<xxx> or Fixes #<xxx> (replace<xxx> with issue number)
  • Tests are added
  • KtLint format has been applied on source code itself and violations are fixed
  • CHANGELOG.md is updated
  • PR description added

Documentation is updated. See difference between snapshot and release documentation

- Provide better message when the backing property does not have a private modifier
- Check that property correlated with the backing property is public

Closes #2345
@paul-dingemans paul-dingemans added this to the 1.1 milestone Nov 8, 2023
@paul-dingemans paul-dingemans merged commit 2bfc5a1 into master Nov 15, 2023
12 checks passed
@paul-dingemans paul-dingemans deleted the 2345-property-name-backing-property branch November 15, 2023 19:54
# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Backing property requires other value to be part of public API
1 participant