Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Fix operator spacing #2473

Merged
merged 1 commit into from
Jan 8, 2024
Merged

Fix operator spacing #2473

merged 1 commit into from
Jan 8, 2024

Conversation

paul-dingemans
Copy link
Collaborator

Description

If an operation reference contains an identifier, then it is used in a DSL notation in which the identifier should be separated with a from a parenthesized expression to avoid confusion with a function call. E.g. format as every { foo() } returns (bar) andThen (baz)

Offsets for operators having length 2 or more, and not followed by single space were incorrect as length of the operator was not taken into account.

Closes #2459

Checklist

Before submitting the PR, please check following (checks which are not relevant may be ignored):

  • Commit message are well written. In addition to a short title, the commit message also explain why a change is made.
  • At least one commit message contains a reference Closes #<xxx> or Fixes #<xxx> (replace<xxx> with issue number)
  • Tests are added
  • KtLint format has been applied on source code itself and violations are fixed
  • PR title is short and clear (it is used as description in the release changelog)
  • PR description added (background information)

Documentation is updated. See difference between snapshot and release documentation

  • Snapshot documentation in case documentation is to be released together with a code change
  • Release documentation in case documentation is related to a released version of ktlint and has to be published as soon as the change is merged to master

If an operation reference contains an identifier, then it is used in a DSL notation in which the identifier should be separated with a from a parenthesized expression to avoid confusion with a function call. E.g. format as `every { foo() } returns (bar) andThen (baz)`

Offsets for operators having length 2 or more, and not followed by single space were incorrect as length of the operator was not taken into account.

Closes #2459
@paul-dingemans paul-dingemans added this to the 1.2 milestone Dec 29, 2023
@paul-dingemans paul-dingemans modified the milestones: 1.2, 1.1.1 Jan 8, 2024
@paul-dingemans paul-dingemans merged commit d69eb99 into master Jan 8, 2024
12 checks passed
@paul-dingemans paul-dingemans deleted the 2459-operator-spacing branch January 8, 2024 17:33
# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

infix-spacing
1 participant