Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Ignore EOL comment that causes max_line_length to be exceeded, except in max-line-length rule #2516

Merged
merged 1 commit into from
Jan 28, 2024

Conversation

paul-dingemans
Copy link
Collaborator

Description

Ignore EOL comment that causes max_line_length to be exceeded, except in max-line-length rule

Rules should not start wrapping code in case the max_line_length is exceeded because of the EOL comment. The developer should determine whether the EOL comment should be shortened, or be placed on a separate line instead of wrapping via autocorrect.

Closes #2450

Checklist

Before submitting the PR, please check following (checks which are not relevant may be ignored):

  • Commit message are well written. In addition to a short title, the commit message also explain why a change is made.
  • At least one commit message contains a reference Closes #<xxx> or Fixes #<xxx> (replace<xxx> with issue number)
  • Tests are added
  • KtLint format has been applied on source code itself and violations are fixed
  • PR title is short and clear (it is used as description in the release changelog)
  • PR description added (background information)

Documentation is updated. See difference between snapshot and release documentation

  • Snapshot documentation in case documentation is to be released together with a code change
  • Release documentation in case documentation is related to a released version of ktlint and has to be published as soon as the change is merged to master

… in max-line-length rule

Rules should not start wrapping code in case the max_line_length is exceeded because of the EOL comment. The developer should determine whether the EOL comment should be shortened, or be placed on a separate line instead of wrapping via autocorrect.

Closes #2450
@paul-dingemans paul-dingemans added this to the 1.2 milestone Jan 28, 2024
@paul-dingemans paul-dingemans merged commit 705221b into master Jan 28, 2024
22 checks passed
@paul-dingemans paul-dingemans deleted the 2450-eol-comments-max-line-length branch January 28, 2024 15:11
# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

argument-list-wrapping should ignore comments at the end of the line
1 participant