Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

2550 clikt #2556

Merged
merged 9 commits into from
Feb 24, 2024
Merged

2550 clikt #2556

merged 9 commits into from
Feb 24, 2024

Conversation

paul-dingemans
Copy link
Collaborator

@paul-dingemans paul-dingemans commented Feb 20, 2024

Description

Clikt is a kotlin library which allows more Kotlin native code. Also, it is blocking minifying the ktlint jar.

Closes #2550

Checklist

Before submitting the PR, please check following (checks which are not relevant may be ignored):

  • Commit message are well written. In addition to a short title, the commit message also explain why a change is made.
  • At least one commit message contains a reference Closes #<xxx> or Fixes #<xxx> (replace<xxx> with issue number)
  • Tests are added
  • KtLint format has been applied on source code itself and violations are fixed
  • PR title is short and clear (it is used as description in the release changelog)
  • PR description added (background information)

Documentation is updated. See difference between snapshot and release documentation

  • Snapshot documentation in case documentation is to be released together with a code change
  • Release documentation in case documentation is related to a released version of ktlint and has to be published as soon as the change is merged to master

Janino is required for logback-test.xml conditional configuration so that trace-logging in unit test can be automatically enabled using an environment variable

This (partially) reverts commit a6e6b55.
Clikt is a kotlin library which allows more Kotlin native code. Also, it is blocking minifying the ktlint jar.

Closes #2550
@paul-dingemans paul-dingemans added this to the 1.2 milestone Feb 20, 2024
Janino is required for logback-test.xml conditional configuration so that trace-logging in unit test can be automatically enabled using an environment variable

This (partially) reverts commit a6e6b55.

data class PatternsFromStdin(
val delimiter: String,
) : StdinOption()
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unused?

@Goooler
Copy link
Contributor

Goooler commented Feb 20, 2024

One more thing, this PR needs a rebase to drop 6ff4d8a.

Clikt is a kotlin library which allows more Kotlin native code. Also, it is blocking minifying the ktlint jar.

Closes #2550
# Conflicts:
#	ktlint-cli/src/main/kotlin/com/pinterest/ktlint/cli/internal/KtlintCommandLine.kt
@paul-dingemans paul-dingemans merged commit cb17bbf into master Feb 24, 2024
12 checks passed
@paul-dingemans paul-dingemans deleted the 2550-clikt branch February 24, 2024 15:26
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Migrate from Picocli to Clikt
2 participants