Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Fix unwanted whitespace between super class constructor and its argument list #2630

Merged

Conversation

tKe
Copy link
Contributor

@tKe tKe commented Apr 10, 2024

Description

Adds support for detecting whitespace before a value argument list when it follows the type argument list of a constructor call.

This is needed to correctly detect and remove the excess whitespace in the following sample:

class MyClass : MySuper<String> ("hello")

Checklist

Before submitting the PR, please check following (checks which are not relevant may be ignored):

  • Commit message are well written. In addition to a short title, the commit message also explain why a change is made.
  • At least one commit message contains a reference Closes #<xxx> or Fixes #<xxx> (replace<xxx> with issue number)
  • Tests are added
  • KtLint format has been applied on source code itself and violations are fixed
  • PR title is short and clear (it is used as description in the release changelog)
  • PR description added (background information)

Documentation is updated. See difference between snapshot and release documentation

  • Snapshot documentation in case documentation is to be released together with a code change
  • Release documentation in case documentation is related to a released version of ktlint and has to be published as soon as the change is merged to master

tKe and others added 2 commits April 10, 2024 18:18
SpacingAroundParensRule wasn't applying in the case of a parameter list following a type argument list as expected in a generic super-class constructor call.
@paul-dingemans
Copy link
Collaborator

Tnx for your contribution. I have added similar logic to the class-signature rule which in the long run might replace (parts of) the paren-spacing rule.

@paul-dingemans paul-dingemans changed the title Fix paren-spacing rule for generic superclass constructor Fix unwanted whitespace between super class constructor and its argument list Apr 16, 2024
@paul-dingemans paul-dingemans added this to the 1.2.2 milestone Apr 16, 2024
@paul-dingemans paul-dingemans merged commit 0502a2b into pinterest:master Apr 16, 2024
11 checks passed
paul-dingemans added a commit that referenced this pull request Jun 4, 2024
# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants