Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Prevent conflict between multiline-expression-wrapping and function-signature #2775

Merged
merged 2 commits into from
Aug 28, 2024

Conversation

paul-dingemans
Copy link
Collaborator

Description

Prevent conflict between multiline-expression-wrapping and function-signature

When function-signature rule is configured with ktlint_function_signature_body_expression_wrapping set to default then the first line of a multiline expression body should be kept on the same line as the end of function signature, as long as max line length is not exceeded. In this case the multiline-expression-wrapping rule has to ignore the multiline function expression body.

Closes #2650

Checklist

Before submitting the PR, please check following (checks which are not relevant may be ignored):

  • Commit message are well written. In addition to a short title, the commit message also explain why a change is made.
  • At least one commit message contains a reference Closes #<xxx> or Fixes #<xxx> (replace<xxx> with issue number)
  • Tests are added
  • KtLint format has been applied on source code itself and violations are fixed
  • PR title is short and clear (it is used as description in the release changelog)
  • PR description added (background information)

Documentation is updated. See difference between snapshot and release documentation

  • Snapshot documentation in case documentation is to be released together with a code change
  • Release documentation in case documentation is related to a released version of ktlint and has to be published as soon as the change is merged to master

…n-signature`

When `function-signature` rule is configured with `ktlint_function_signature_body_expression_wrapping` set to `default` then the first line of a multiline expression body should be kept on the same line as the end of function signature, as long as max line length is not exceeded. In this case the `multiline-expression-wrapping` rule has to ignore the multiline function expression body.

Closes #2650
@paul-dingemans paul-dingemans added this to the 1.4.0 milestone Aug 20, 2024
@paul-dingemans paul-dingemans merged commit 64dfcba into master Aug 28, 2024
22 checks passed
@paul-dingemans paul-dingemans deleted the 2650-multiline-expression-wrapping branch August 28, 2024 17:09
# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Prevent possible conflict between multiline-expression-wrapping and function-signature body wrapping
1 participant