Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Remove HEADER_KEYWORD & IMPL_KEYWORD #2810

Merged
merged 1 commit into from
Sep 24, 2024

Conversation

3flex
Copy link
Contributor

@3flex 3flex commented Sep 20, 2024

Description

Remove calls to KtTokens.HEADER_KEYWORD & KtTokens.IMPL_KEYWORD. These have been removed from Kotlin effective Kotlin 2.1.0-Beta1.

Without this change, projects that use ktlint-rule-engine-core as a dependency cannot build when upgraded to Kotlin-2.1.0-Beta1.

References:

Checklist

Before submitting the PR, please check following (checks which are not relevant may be ignored):

  • Commit message are well written. In addition to a short title, the commit message also explain why a change is made.
  • At least one commit message contains a reference Closes #<xxx> or Fixes #<xxx> (replace<xxx> with issue number)
  • Tests are added
  • KtLint format has been applied on source code itself and violations are fixed
  • PR title is short and clear (it is used as description in the release changelog)
  • PR description added (background information)

Documentation is updated. See difference between snapshot and release documentation

  • Snapshot documentation in case documentation is to be released together with a code change
  • Release documentation in case documentation is related to a released version of ktlint and has to be published as soon as the change is merged to master

Remove calls to `KtTokens.HEADER_KEYWORD` & `KtTokens.IMPL_KEYWORD`.
These have been removed from Kotlin effective Kotlin 2.1.0-Beta1.
@paul-dingemans paul-dingemans merged commit 1c2ec01 into pinterest:master Sep 24, 2024
20 checks passed
@paul-dingemans paul-dingemans added this to the 1.4.0 milestone Sep 24, 2024
@3flex 3flex deleted the kotlin-2.1.0 branch September 24, 2024 21:28
# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants