Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Do not remove imports for which the fully qualified path is identical to the package name #2822

Merged
merged 1 commit into from
Oct 4, 2024

Conversation

paul-dingemans
Copy link
Collaborator

Description

Do not remove imports for which the fully qualified path is identical to the package name

In rare cases this could lead to code which no longer can be compiled

Closes #2821

Checklist

Before submitting the PR, please check following (checks which are not relevant may be ignored):

  • Commit message are well written. In addition to a short title, the commit message also explain why a change is made.
  • At least one commit message contains a reference Closes #<xxx> or Fixes #<xxx> (replace<xxx> with issue number)
  • Tests are added
  • KtLint format has been applied on source code itself and violations are fixed
  • PR title is short and clear (it is used as description in the release changelog)
  • PR description added (background information)

Documentation is updated. See difference between snapshot and release documentation

  • Snapshot documentation in case documentation is to be released together with a code change
  • Release documentation in case documentation is related to a released version of ktlint and has to be published as soon as the change is merged to master

… to the package name

In rare cases this could lead to code which no longer can be compiled

Closes #2821
@paul-dingemans paul-dingemans added this to the 1.4.0 milestone Oct 3, 2024
@paul-dingemans paul-dingemans merged commit ac6106c into master Oct 4, 2024
10 checks passed
@paul-dingemans paul-dingemans deleted the 2821 branch October 4, 2024 08:47
# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ktlint incorrectly removes a used import
1 participant