Catch java.lang.NoSuchFieldError when looking for WHEN_ENTRY_GUARD in kotlin version 2.0.1 #2857
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… kotlin version 2.0.1 As this exception was not caught in the rule, and also not in the RuleExecutionContext it terminated linting/formatting of files containing a WHEN_ENTRY with an exception. In the Ktlint CLI this exception was swallowed. In ktlint-intellij-plugin the exception was recorded and became visible to users. Closes #2856
orchestr7
added a commit
to saveourtool/diktat
that referenced
this pull request
Dec 7, 2024
### What's done: - Occasionally Kotlin decided to remove several AST Nodes JetBrains/kotlin@76592dc - There also was such kind of bug caused by Kotlin2 in ktlint pinterest/ktlint#2857 - Also removed Werror flag due to one deprecation warning which we are not able to fix - Updated tests and Kotlin version to 2.1 in resources - Fixed some detekt deprecation warnings - Replaced gradle configuration with new compilerOptions API
orchestr7
added a commit
to saveourtool/diktat
that referenced
this pull request
Dec 7, 2024
### What's done: - Occasionally Kotlin decided to remove several AST Nodes JetBrains/kotlin@76592dc - There also was such kind of bug caused by Kotlin2 in ktlint pinterest/ktlint#2857 - Removed `-Werror` flag due to one deprecation warning which we are not able to fix - Updated tests and Kotlin version to 2.1 in resources - Fixed some detekt deprecation warnings - Replaced gradle configuration with new compilerOptions API - Removed unused methods which caused warnings - Updated sarif4k: it caused an error with missing 'void io.github.detekt.sarif4k.ToolComponent.<init> Co-authored-by: akuleshov7 <andrewkuleshov7@gmail.com> Co-authored-by: orchestr7 <bonycatbony@gmail.com>
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Catch java.lang.NoSuchFieldError when looking for WHEN_ENTRY_GUARD in kotlin version 2.0.1
As this exception was not caught in the rule, and also not in the RuleExecutionContext it terminated linting/formatting of files containing a WHEN_ENTRY with an exception. In the Ktlint CLI this exception was swallowed. In ktlint-intellij-plugin the exception was recorded and became visible to users.
Closes #2856
Checklist
Before submitting the PR, please check following (checks which are not relevant may be ignored):
Closes #<xxx>orFixes #<xxx>(replace<xxx>with issue number)Documentation is updated. See difference between snapshot and release documentation