Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Try to discover .git instead of hardcoding. #623

Merged
merged 1 commit into from
Oct 17, 2019
Merged

Try to discover .git instead of hardcoding. #623

merged 1 commit into from
Oct 17, 2019

Conversation

erik
Copy link
Contributor

@erik erik commented Oct 17, 2019

Very minor convenience improvement.

Previously we assumed that we were always in the root of the repo for
installing Git hooks. Instead, call rev-parse --show-toplevel to
discover the root of the repo, which lets us call
--install-pre-{commit,push}-hook from anywhere inside a Git repository.

Very minor convenience improvement.

Previously we assumed that we were always in the root of the repo for
installing Git hooks. Instead, call `rev-parse --show-toplevel` to
discover the root of the repo, which lets us call
`--install-pre-{commit,push}-hook` from anywhere inside a Git repository.
@shashachu
Copy link
Contributor

Thanks for the fix!

@shashachu shashachu merged commit e0b4830 into pinterest:master Oct 17, 2019
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants