Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

AnnotationRule fixes/enhancements #624

Merged
merged 4 commits into from
Dec 3, 2019
Merged

AnnotationRule fixes/enhancements #624

merged 4 commits into from
Dec 3, 2019

Conversation

shashachu
Copy link
Contributor

@shashachu shashachu commented Oct 17, 2019 •
edited
Loading

  • Fixing autoCorrect logic to ensure we're doing no work unless there is a lint violation
  • Restructuring code slightly to allow ktlint to do a more standard node traversal
  • Adding support for file annotations

@shashachu shashachu requested a review from Tapchicoma October 17, 2019 23:12
@shashachu
AnnotationRule fixes/enhancements
5535f32 
    * Fixing autoCorrect loging to ensure we're doing no work unless there is a lint violation
    * Restructuring code slightly to allow ktlint to do a more standard node traversal
    * Adding support for file annotations
Tapchicoma
Tapchicoma approved these changes Nov 5, 2019
View reviewed changes
Copy link
Collaborator

@Tapchicoma Tapchicoma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@shashachu shashachu merged commit e0bc60c into pinterest:master Dec 3, 2019
@shashachu shashachu deleted the annotation-fix branch June 8, 2020 22:40
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@Tapchicoma Tapchicoma Tapchicoma approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@shashachu @Tapchicoma