Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

ArgumentListWrappingRule: don't report it when line breaks is inside a lambda #928

Merged
merged 2 commits into from
Sep 28, 2020
Merged

ArgumentListWrappingRule: don't report it when line breaks is inside a lambda #928

merged 2 commits into from
Sep 28, 2020

Conversation

t-kameyama
Copy link
Contributor

Fixes #861
Fixes #870

romtsn
romtsn reviewed Sep 28, 2020
View reviewed changes
...al/src/test/kotlin/com/pinterest/ktlint/ruleset/experimental/ArgumentListWrappingRuleTest.kt Outdated
@@ -254,9 +285,9 @@ class ArgumentListWrappingRuleTest {
}

@Test
fun testFormatPreservesIndentWithAnnotationsOnMultiLine() {
fun testLintPreservesIndentWithAnnotationsOnMultiLine() {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hm, why this has been changed?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Undid the test.

@t-kameyama t-kameyama requested a review from romtsn September 28, 2020 11:31
@romtsn
Copy link
Collaborator

romtsn commented Sep 28, 2020

Perfect, thank you!

@romtsn romtsn merged commit 140fba5 into pinterest:master Sep 28, 2020
@t-kameyama t-kameyama deleted the issue_861 branch September 28, 2020 18:14
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@romtsn romtsn Awaiting requested review from romtsn

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@t-kameyama @romtsn