Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Move R/W deadline into ReadWriteCloser #234

Closed
wants to merge 1 commit into from
Closed

Conversation

cnderrauber
Copy link
Member

New interface can't pass pion/webrtc's
API check, add r/w deadline to the ReadWriteCloser
should work for existed codes.

Description

Reference issue

Fixes #...

New interface can't pass pion/webrtc's
API check.
Copy link

codecov bot commented Dec 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 65.67%. Comparing base (687754f) to head (2c9da9e).

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #234   +/-   ##
=======================================
  Coverage   65.67%   65.67%           
=======================================
  Files           4        4           
  Lines         335      335           
=======================================
  Hits          220      220           
  Misses         90       90           
  Partials       25       25           
Flag Coverage Δ
go 65.67% <ø> (ø)
wasm 65.67% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cnderrauber
Copy link
Member Author

ok, it is failed by API check in this repo now..

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants