Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Fixing Stride Handling for OpenH264 #381

Merged
merged 1 commit into from
Mar 8, 2022
Merged

Conversation

adamroach
Copy link
Contributor

The golang image.YCbCr struct can contain fields of arbitrary stride
lengths, which don't necessarily match the field widths. This
patch passes the stride values from the image.YCbCr struct into
the OpenH264 encode calls.

The golang image.YCbCr struct can contain fields of arbitrary stride
lengths, which don't necessarily match the field widths. This
patch passes the stride values from the image.YCbCr struct into
the OpenH264 encode calls.
@adamroach adamroach requested review from lherman-cs and Sean-Der March 5, 2022 06:45
@codecov
Copy link

codecov bot commented Mar 5, 2022

Codecov Report

Merging #381 (6d04eb9) into master (e316b30) will increase coverage by 0.02%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #381      +/-   ##
==========================================
+ Coverage   46.39%   46.42%   +0.02%     
==========================================
  Files          67       67              
  Lines        4371     4373       +2     
==========================================
+ Hits         2028     2030       +2     
  Misses       2220     2220              
  Partials      123      123              
Impacted Files Coverage Δ
pkg/codec/openh264/openh264.go 73.33% <100.00%> (+0.91%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e316b30...6d04eb9. Read the comment docs.

@Sean-Der Sean-Der requested a review from at-wat March 7, 2022 17:23
@Sean-Der
Copy link
Member

Sean-Der commented Mar 7, 2022

Thanks @adamroach ! LGTM, I am not intimately familiar with the code base so adding @at-wat just in case.

Happy to merge in a day or two otherwise :)

Copy link
Member

@at-wat at-wat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@adamroach adamroach merged commit 9bb5755 into master Mar 8, 2022
@adamroach adamroach deleted the openh264-stride-fix branch March 8, 2022 09:09
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants