Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Implement forced keyframes for x264 #388

Merged
merged 2 commits into from
Apr 5, 2022
Merged

Conversation

zjzhang-cn
Copy link
Member

Description

 实现x264的强制关键帧方法

Reference issue

Fixes #...

@codecov
Copy link

codecov bot commented Mar 28, 2022

Codecov Report

Merging #388 (7d0e84f) into master (548cdac) will decrease coverage by 0.05%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##           master     #388      +/-   ##
==========================================
- Coverage   47.16%   47.11%   -0.06%     
==========================================
  Files          67       67              
  Lines        4380     4387       +7     
==========================================
+ Hits         2066     2067       +1     
- Misses       2189     2195       +6     
  Partials      125      125              
Impacted Files Coverage Δ
pkg/codec/x264/x264.go 63.95% <0.00%> (-0.76%) ⬇️
pkg/driver/camera/camera_linux.go 26.31% <0.00%> (-0.80%) ⬇️
pkg/prop/prop.go 72.10% <0.00%> (+0.19%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 548cdac...7d0e84f. Read the comment docs.

@zjzhang-cn zjzhang-cn requested review from lherman-cs and at-wat March 31, 2022 11:45
Copy link
Member

@at-wat at-wat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zjzhang-cn zjzhang-cn merged commit e780bdc into pion:master Apr 5, 2022
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants