change buffer size to 2 #482
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #482 +/- ##
==========================================
+ Coverage 58.33% 58.83% +0.49%
==========================================
Files 62 62
Lines 3737 3741 +4
==========================================
+ Hits 2180 2201 +21
+ Misses 1430 1413 -17
Partials 127 127
... and 1 file with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
at-wat
reviewed
Mar 27, 2023
pkg/driver/camera/camera_linux.go
Outdated
| @@ -72,6 +72,7 @@ type camera struct { | |||
| mutex sync.Mutex | |||
| cancel func() | |||
| prevFrameTime time.Time | |||
| bufCount int | |||
There was a problem hiding this comment.
Is there a reason it's not
const bufCount = 2?
There was a problem hiding this comment.
No, that's better. Done!
at-wat
reviewed
Mar 28, 2023
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
From the Linux kernel documentation here
This code updates the buffer size from 1 to 2 along with the frame skip logic. The side effect is much higher fps on all 3 of the cameras I've tested, presumably because the buffer is no longer a bottleneck, and there shouldn't be a risk of slowing down any streams.