Add driver unit tests #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stpierre
force-pushed
the
stpierre/driver-unit-tests
branch
from
c3e26fe to
2290c67
Compare
stpierre
changed the title
stpierre
force-pushed
the
stpierre/driver-unit-tests
branch
2 times, most recently
from
9ca6331 to
8b72551
Compare
isaac-ped
reviewed
Apr 10, 2024
test/test_drivers.py
Outdated
Comment on lines
44
to
42
| def __call__( | ||
| self, | ||
| mock_obj: Any, # the k8s model objects have no common superclass | ||
| state: str | None = None, | ||
| state_contains: str | None = None, | ||
| ) -> None: |
There was a problem hiding this comment.
Why have this be a __call__ function rather than like assert_consistent_state() or something like that?
I tried to eliminate as much code duplication as possible without being excessively magical. There's still a healthy amount of duplication, but I'm not sure there's much to be done about it at this point without getting deep into metaprogramming.
stpierre
force-pushed
the
stpierre/driver-unit-tests
branch
from
5fd799f to
b81ed63
Compare
isaac-ped
approved these changes
Apr 12, 2024
| # (https://github.com/kubernetes-client/python/issues/225), and I | ||
| # couldn't get any of the third-party stub packages (e.g., | ||
| # https://pypi.org/project/kubernetes-stubs-elephant-fork/) to work. | ||
| ignore = ["kwait/drivers.py", "test/test_drivers.py"] |
There was a problem hiding this comment.
You might consider this solution: microsoft/pyright#945
So that we can ignore the imports from that module without ignoring typing in those files altogether
There was a problem hiding this comment.
I'm going to merge this as-is and try to work on the typing stuff in a different PR to make it clearer what's happening. This looks promising though....
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.