Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

feat: add support for make codegen/pre-commit through nix #31

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

isubasinghe
Copy link
Collaborator

@isubasinghe isubasinghe commented Jul 25, 2023

NOTE: You need to be inside a nix shell for this to work, use nix develop to get a shell.

Adds support for make codegen, make pre-commit -B commands via nix.
To use nix supply the USE_NIX variable with true when invoking make.
For example make USE_NIX=true pre-commit -B

Signed-off-by: Isitha Subasinghe <isitha@pipekit.io>
@isubasinghe isubasinghe changed the title feat: add support for make codegen through nix feat: add support for make codegen/pre-commit through nix Jul 25, 2023
Signed-off-by: Isitha Subasinghe <isitha@pipekit.io>
@isubasinghe
Copy link
Collaborator Author

@JPZ13 can you have a suss at this, should be trivial ? Can't assign you myself.

@JPZ13 JPZ13 assigned JPZ13 and unassigned JPZ13 Aug 1, 2023
@JPZ13
Copy link
Collaborator

JPZ13 commented Aug 1, 2023

@isubasinghe - pardon the permissions issue. You should now be a maintainer on the repo

I'm also a little strapped for time at the moment. Could you get @Joibel or @rohankmr414 to test it out?

@isubasinghe
Copy link
Collaborator Author

@JPZ13 ah no worries, I will ask @Joibel

@isubasinghe isubasinghe requested a review from Joibel August 1, 2023 22:45
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants