-
-
Notifications
You must be signed in to change notification settings - Fork 110
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
ReadHeaderTimeout is setting a hard timeout on connections regardless of header sending #75
Comments
Hmmm, let me check. |
You are correct. Thanks a ton for reporting. Fixing it now! |
As reported in #75 Signed-off-by: Pires <pjpires@gmail.com>
Fixes #75 Signed-off-by: Pires <pjpires@gmail.com>
Can you, please, help test #75? |
I tested #76 and I got the same results with version |
Additionally, #74 is lacking in picking a suitable default. Considering the reason for that change's existence, it really should include a default timeout. If people really want to have no timeout at all, a negative value could be defined as "no timeout". |
As reported in #75 Signed-off-by: Pires <pjpires@gmail.com>
Fixes #75 Signed-off-by: Pires <pjpires@gmail.com>
The fix was released as https://github.com/pires/go-proxyproto/releases/tag/v0.6.1 |
I think this setting is supposed to timeout connections that are not sending the headers and terminate them after this amount of time. However, I set the setting to 5 seconds, and the result is that all connections are terminated after 5 seconds, even if they correctly sent the headers. The connection starts up, but is then abruptly ended after the 5 seconds are passed.
I think what is missing in #74 is a call to
SetReadDeadline
to reset the timeout after the proxy header was sent successfully.The text was updated successfully, but these errors were encountered: