forked from nodejs/node-gyp
-
Notifications
You must be signed in to change notification settings - Fork 0
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
win: allow node.exe/iojs.exe to be renamed
On Windows, when node or io.js attempts to dynamically load a compiled addon, the compiled addon tries to load node.exe or iojs.exe again - depending on which import library the module used when it was linked. This makes it impossible to rename node.exe or iojs.exe, because when that happens the module can't find its dependencies. With this patch, a delay-load hook is added to all modules that are compiled with node-gyp. The delay-load hook ensures that whenever a module tries to load imports from node.exe/iojs.exe, it'll just refer back to the process image, thus making it possible to rename the iojs/node binary. Bug: nodejs/node#751 Bug: nodejs/node#965 Downstream PR: nodejs/node#1251
- Loading branch information
1 parent
abad2b5
commit 5c82901
Showing
2 changed files
with
44 additions
and
0 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,32 @@ | ||
/* | ||
* When this file is linked to a DLL, it sets up a delay-load hook that | ||
* intervenes when the DLL is trying to load 'node.exe' or 'iojs.exe' | ||
* dynamically. Instead of trying to locate the .exe file it'll just return | ||
* a handle to the process image. | ||
* | ||
* This allows compiled addons to work when node.exe or iojs.exe is renamed. | ||
*/ | ||
|
||
#ifdef _MSC_VER | ||
|
||
#define WIN32_LEAN_AND_MEAN | ||
#include <windows.h> | ||
|
||
#include <delayimp.h> | ||
#include <string.h> | ||
|
||
static FARPROC WINAPI load_exe_hook(unsigned int event, DelayLoadInfo* info) { | ||
if (event != dliNotePreLoadLibrary) | ||
return NULL; | ||
|
||
if (_stricmp(info->szDll, "iojs.exe") != 0 && | ||
_stricmp(info->szDll, "node.exe") != 0) | ||
return NULL; | ||
|
||
HMODULE m = GetModuleHandle(NULL); | ||
return (FARPROC) m; | ||
} | ||
|
||
PfnDliHook __pfnDliNotifyHook2 = load_exe_hook; | ||
|
||
#endif |