Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Ensures FastText returns consistent dtypes #1638

Merged
merged 1 commit into from
Oct 24, 2017
Merged

Ensures FastText returns consistent dtypes #1638

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion gensim/models/wrappers/fasttext.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -90,7 +90,7 @@ def word_vec(self, word, use_norm=False):
if word in self.vocab:
return super(FastTextKeyedVectors, self).word_vec(word, use_norm)
else:
word_vec = np.zeros(self.syn0_ngrams.shape[1])
word_vec = np.zeros(self.syn0_ngrams.shape[1], dtype=np.float32)
ngrams = compute_ngrams(word, self.min_n, self.max_n)
ngrams = [ng for ng in ngrams if ng in self.ngrams]
if use_norm:
Expand Down
11 changes: 11 additions & 0 deletions gensim/test/test_fasttext_wrapper.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -337,6 +337,17 @@ def testHash(self):
ft_hash = fasttext.ft_hash('word')
self.assertEqual(ft_hash, 1788406269)

def testConsistentDtype(self):
"""Test that the same dtype is returned for OOV words as for words in the vocabulary"""
vocab_word = 'night'
oov_word = 'wordnotpresentinvocabulary'
self.assertIn(vocab_word, self.test_model.wv.vocab)
self.assertNotIn(oov_word, self.test_model.wv.vocab)

vocab_embedding = self.test_model[vocab_word]
oov_embedding = self.test_model[oov_word]
self.assertEqual(vocab_embedding.dtype, oov_embedding.dtype)


if __name__ == '__main__':
logging.basicConfig(format='%(asctime)s : %(levelname)s : %(message)s', level=logging.DEBUG)
Expand Down