-
-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Fix 1651: make word_vec() return immutable vector #1662
Merged
Merged
Changes from 4 commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
9dae6e2
fix for issue about mutable vector returned by KeyedVectors.word_vector
CLearERR 7e7778c
fix for previous fix
CLearERR 42f480a
Added negative testfor word_vec, also returned not-a-word check
CLearERR f467a9f
fix PEP8
menshikh-iv b042209
Change test name
menshikh-iv File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -278,9 +278,12 @@ def word_vec(self, word, use_norm=False): | |
""" | ||
if word in self.vocab: | ||
if use_norm: | ||
return self.syn0norm[self.vocab[word].index] | ||
result = self.syn0norm[self.vocab[word].index] | ||
else: | ||
return self.syn0[self.vocab[word].index] | ||
result = self.syn0[self.vocab[word].index] | ||
|
||
result.setflags(write=False) | ||
return result | ||
else: | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Why you remove this branch? We must raise an exception if word not in the dictionary. |
||
raise KeyError("word '%s' not in vocabulary" % word) | ||
|
||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -386,6 +386,12 @@ def test_delete_temporary_training_data(self): | |
self.model_sanity(model, keep_training=False) | ||
self.assertTrue(hasattr(model, 'syn1neg')) | ||
|
||
def test_word_vec(self): | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. More-descriptive name would be better, such as |
||
model = keyedvectors.KeyedVectors.load_word2vec_format(datapath('word2vec_pre_kv_c')) | ||
vector = model['says'] | ||
with self.assertRaises(ValueError): | ||
vector *= 0 | ||
|
||
@log_capture() | ||
def testBuildVocabWarning(self, l): | ||
"""Test if logger warning is raised on non-ideal input to a doc2vec model""" | ||
|
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add test to check this behaviour (with Exception catching)