Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Fix Numpy deprecation warning in matutils.corpus2dense #2433

Closed
wants to merge 36 commits into from
Closed

Fix Numpy deprecation warning in matutils.corpus2dense #2433

wants to merge 36 commits into from

Conversation

PeteBleackley
Copy link
Contributor

Fix for issue #2432. This is a one line change (generator to list comprehension)

PeteBleackley and others added 30 commits November 23, 2017 15:28
…cement of a parenthesis. Updated predicted values for unit tests
@piskvorky
Copy link
Owner

Thanks @PeteBleackley . That doesn't look like a 1-line change though, and there are conflicts.

Can you rebase your changes on top of current develop branch?

@PeteBleackley
Copy link
Contributor Author

@piskvorky It should be a one line change. For some reason git has included all the commits from my previous 2 PRs (it lives up to its name). I had tried to make sure that I was synced to the latest version of the develop branch before making my changes as well. I'll have to try again.

@piskvorky
Copy link
Owner

You could also start from gensim's develop directly, by doing a hard reset: git reset --hard gensim/develop. And after that, re-apply your one-liner.

That way, there's no risk your "local" develop branch already diverged from upstream develop.

@mpenkov
Copy link
Collaborator

mpenkov commented Apr 20, 2019

@PeteBleackley Are you able to rebase?

@mpenkov
Copy link
Collaborator

mpenkov commented Apr 28, 2019

This has already been fixed as part of #2371

@mpenkov mpenkov closed this Apr 28, 2019
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants