Declare variables prior to for loop in fastss.pyx for ANSI C compatibility #3378
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
piskvorky
changed the title
|
Thank you! @mpenkov the CI failures seem unrelated to this PR's changes. Could you please check what's going on? |
piskvorky
approved these changes
Aug 11, 2022
|
Yes, the failure looks unrelated. Let me fix the failure first, and then merge this. I've been a bit overwhelmed recently, will try to catch up on gensim stuff soon. |
…377_for_loop_init_decl
mpenkov
changed the title
|
Merged. Thank you @hstk30 !! |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3377.
I meet the error when I install
gensim==4.2.0, mentioned in #3377I guess some platform's (like my laptop)
gccnot fitcstandard, so I change the code to meet theANSI C, I think it will fit all platform.