n_similarity() in word2vec and doc2vec raises ValueError if an empty list is passed #761
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -6,6 +6,7 @@ Changes | |||
| - In hdpmodel and dtmmodel | |||
| - NOT BACKWARDS COMPATIBLE! | |||
| * Added random_state parameter to LdaState initializer and check_random_state() (@droudy, #113) | |||
| * `n_similarity()` raises `ValueError` if an empty list is passed to it in word2vec, doc2vec (@droudy, #761) | |||
There was a problem hiding this comment.
@tmylk now that CHANGELOG is markdown (rather than plaintext), let's add links as true links: people's profiles, links to pull requests, links to supporting research articles...
|
@droudy Could you please rebase your branch so that the merge conflicts are resolved? Thanks |
|
@tmylk I have resolved merge conflicts Travis build fails for python 2.6, build stalls at |
|
Needs rebase and then can be merged |
|
Fixed in #883 |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #743