Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

ebuild.profiles: Fix case where a parent path omits the repo identifier #435

Closed
wants to merge 1 commit into from

Conversation

chewi
Copy link
Contributor

@chewi chewi commented Jun 11, 2024

It is valid to have a parent path like :path/to/profile where the repo identifier is missing. This refers to a path in the current repo.

@thesamesam
Copy link
Member

To be clear, it's valid (presumably) for portage-2. Maybe link if you can to where Portage declares this is supposed to be supported?

@chewi
Copy link
Contributor Author

chewi commented Jun 12, 2024

It states this in man portage.

If layout.conf is new enough, you can also use the <repo>:<path> syntax. The <repo> is the same string as is stored in the repo_name file (or omitted to refer to the current repo), and <path> is a subdir starting at profiles/.

I've now mentioned it in the commit message.

@ferringb
Copy link
Contributor

ferringb commented Jun 12, 2024

LGTM, however the merge must be done and then pulled to gentoo side last I knew.

According "SPECIFIC FILE DESCRIPTIONS" in `man portage`, it is valid to
have a parent path like `:path/to/profile` where the repo identifier is
missing. This refers to a path in the current repo.

Signed-off-by: James Le Cuirot <chewi@gentoo.org>
@chewi
Copy link
Contributor Author

chewi commented Jun 12, 2024

Fixed the Signed-off-by address.

@chewi chewi deleted the parent-no-repo branch June 14, 2024 10:48
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants