Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

libpkgx sets XDG_DATA_DIRS in some cases #70

Closed
jhheider opened this issue Apr 27, 2024 · 2 comments · Fixed by #76
Closed

libpkgx sets XDG_DATA_DIRS in some cases #70

jhheider opened this issue Apr 27, 2024 · 2 comments · Fixed by #76

Comments

@jhheider
Copy link
Contributor

it appears that this interferes with the proper functioning of e.g. gsettings from GNOME. since tools use the standard-defined defaults if the value is unset, i think we need to consider that if we add values to it, we must first add the standards-defined fallback to prevent changing behavior. see the below thread for an example of how it interfere's with GNOME's tooling.

          Oh. Maybe we have a bug in pkgx then?
env | grep XDG
XDG_RUNTIME_DIR=/run/user/1002/pkgx env | grep XDG
XDG_DATA_DIRS=/home/felipecrs/.pkgx/gnu.org/coreutils/v9.5.0/share
XDG_RUNTIME_DIR=/run/user/1002/

If pkgx was not supposed to alter XDG_ vars in runtime, then it was not supposed to inject XDG_DATA_DIRS either, I suppose.

Originally posted by @felipecrs in pkgxdev/pantry#5991 (comment)

@mxcl
Copy link
Member

mxcl commented Sep 6, 2024

Sounds right. What's the default?

@jhheider
Copy link
Contributor Author

jhheider commented Sep 6, 2024

If $XDG_DATA_DIRS is either not set or empty, a value equal to /usr/local/share/:/usr/share/ should be used.

ref: https://specifications.freedesktop.org/basedir-spec/latest/index.html#variables

mxcl added a commit that referenced this issue Sep 6, 2024
@mxcl mxcl closed this as completed in #76 Sep 6, 2024
@mxcl mxcl closed this as completed in 572154c Sep 6, 2024
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants