Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

pkgx deno compile --target aarch64-apple-darwin main.ts on linux always generate executable for linux #6790

Closed
tsirysndr opened this issue Jul 23, 2024 · 6 comments · Fixed by #6791

Comments

@tsirysndr
Copy link
Contributor

tsirysndr commented Jul 23, 2024

pkgx deno compile -A --output main --target aarch64-apple-darwin main.ts on linux always generate executable for linux.

$ file main
main: ELF 64-bit LSB pie executable, x86-64, version 1 (SYSV), dynamically linked, interpreter /lib64/ld-linux-x86-64.so.2, for GNU/Linux 3.2.0, not stripped
@jhheider
Copy link
Contributor

I wonder if that's related to this: denoland/deno#22690

Does it work with older version? if you do pkgx +deno~1.40 deno compile... does it help?

@jhheider
Copy link
Contributor

note that you also have two --output statements to the same destination. i don't know if that significant with the placement order of flags.

@tsirysndr
Copy link
Contributor Author

it appears the issue is not related to Deno itself but rather to the Deno installation from pkgx. It works pretty good in ubuntu:latest and deno:latest

@jhheider
Copy link
Contributor

And those are the up-to-date version as well? I can look into it, but based on that issue versions was my first guess.

@tsirysndr
Copy link
Contributor Author

Yes, I can confirm that I am using the latest version of deno (1.45.3)

@jhheider
Copy link
Contributor

ok, interesting one. the problem is this:

runtime:
  env:
    DENORT_BIN: '{{prefix}}/bin/denort'

so, that line is there because their recently-added linux/aarch64 support targeted the glibc for ubuntu22.04 and we support much further back than that. if i comment that out, i can cross-build the apple targets (with unzip) as it grabs their downloadable runtime.

so, I think for now, I'm going to remove this, and explicitly set it in the test stanza. we'll need to update the couple of builds that rely on it (pkgx) being one of them, but that's not a big deal. when i merge this, it should Just Work™ for you without needing to wait on the build, since we're just changing the configuration. should be ready shortly.

jhheider added a commit that referenced this issue Jul 23, 2024
setting the runtime explicitly breaks cross-compilation. instead, we'll set the runtime for our builds of linux/aarch64 _only_ since that's where it's needed.

closes #6790
@jhheider jhheider mentioned this issue Jul 23, 2024
jhheider added a commit that referenced this issue Jul 23, 2024
setting the runtime explicitly breaks cross-compilation. instead, we'll set the runtime for our builds of linux/aarch64 _only_ since that's where it's needed.

closes #6790
jhheider added a commit that referenced this issue Jul 23, 2024
setting the runtime explicitly breaks cross-compilation. instead, we'll set the runtime for our builds of linux/aarch64 _only_ since that's where it's needed.

closes #6790
jhheider added a commit that referenced this issue Jul 23, 2024
setting the runtime explicitly breaks cross-compilation. instead, we'll set the runtime for our builds of linux/aarch64 _only_ since that's where it's needed.

closes #6790
jhheider added a commit that referenced this issue Jul 23, 2024
setting the runtime explicitly breaks cross-compilation. instead, we'll set the runtime for our builds of linux/aarch64 _only_ since that's where it's needed.

closes #6790
jhheider added a commit that referenced this issue Jul 23, 2024
setting the runtime explicitly breaks cross-compilation. instead, we'll set the runtime for our builds of linux/aarch64 _only_ since that's where it's needed.

closes #6790
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants