Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Issue with Arabic layout in Internet Explorer #182

Closed
amandastevens opened this issue Apr 12, 2020 · 8 comments
Closed

Issue with Arabic layout in Internet Explorer #182

amandastevens opened this issue Apr 12, 2020 · 8 comments

Comments

@amandastevens
Copy link

PKP PS client @hkamareddineiiit reported that when using the Health Sciences theme on the journal's OJS 3.1.1 site, everything displays fine in Chrome and Firefox, but in Internet Explorer the direction of the template and text are from left to right which is wrong for Arabic. The client added a direction tag in html for some of them, but can't control others and the template itself.

Here are the affected pages:

https://citj.org/index.php/citj/issue/view/291
https://citj.org/index.php/citj/issue/view/291
https://citj.org/index.php/citj/about/AimsAndScope
https://citj.org/index.php/citj/about/openaccess
https://citj.org/index.php/citj/about/submissions

Tagging the client in case there are follow-up questions.

@Vitaliy-1
Copy link
Collaborator

Internet Explorer doesn't support initial global property value: https://developer.mozilla.org/en-US/docs/Web/CSS/initial

Vitaliy-1 added a commit that referenced this issue Apr 13, 2020
Vitaliy-1 added a commit that referenced this issue Apr 13, 2020
Vitaliy-1 added a commit that referenced this issue Apr 13, 2020
@Vitaliy-1
Copy link
Collaborator

I don't have IE to test but it should work. Just let me know if doesn't. The commits are to master, stable-3_1_2, and stable-3_1_1 branches of the theme plugin. If all works as expected the issue can be closed.

@hkamareddineiiit
Copy link

Hello and thank you for your support. Unfortunately it still doesn't look aligned from right to left. I attached 2 screen shots as an example. The text and buttons should all be aligned from right to left.
Let me know if you need anything else. best, huda

IE RTL 1
IE RTL 2

@hkamareddineiiit
Copy link

Note: you could check the right direction by looking at www.citj.org in Chrome. Thanks!

@Vitaliy-1
Copy link
Collaborator

Hi @hkamareddineiiit,

I don't see that that change is applied. I'm not sure how you add it.
If uploading custom CSS, it should look like:

body[dir="rtl"] {
  text-align: right;
}

If updating with Git, make sure to checkout the branch of the plugin that corresponds to OJS version.
It also may require clearing template and browser cache.

@hkamareddineiiit
Copy link

I don't use CSS. Perhaps @amandastevens can help?

@amandastevens
Copy link
Author

@hkamareddineiiit, you will need to create and upload a custom stylesheet under Website Settings > Appearance > Journal Stylesheet. A CSS can be used to make minor adjustments to the theme. There are instructions on how to do it in the Designing Your Journal Guide.

@hkamareddineiiit
Copy link

hkamareddineiiit commented Apr 13, 2020

Done! Thank you both! @amandastevens @Vitaliy-1.

Not sure how to close this ticket though!

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants