Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Add icons still missing after recent update #34

Closed
1 of 5 tasks
Potherca opened this issue Jan 9, 2022 · 5 comments · Fixed by #37
Closed
1 of 5 tasks

Add icons still missing after recent update #34

Potherca opened this issue Jan 9, 2022 · 5 comments · Fixed by #37
Assignees
Milestone

Comments

@Potherca
Copy link
Member

Potherca commented Jan 9, 2022

The recent update from #31 update (almost) all icons. Besides from some image corruption (being addressed in #32), it needs to be checked that none of the requested icon are missing.

From the overview of #29, the following icon might be missing:

  • Azure App Configuration
  • Azure Purview
  • Generic "Internet" cloud that looks "azure-ish"

Also, the currently open MRs could also contain icons that are not in the current set:

Both need to be verified, and either marked as complete or have a linked issue or MR that adds them.

This issue is a follow-up to #29 and related MR(s).

@Potherca Potherca pinned this issue Jan 9, 2022
@asos-eugeneniemand
Copy link

asos-eugeneniemand commented Jan 21, 2022

I see a PowerBI Embedded but no Native PowerBI is this by design? Also PurView will be handy

@Potherca
Copy link
Member Author

@asos-eugeneniemand Purview icons will be added as part of #37

@Potherca Potherca linked a pull request Jan 24, 2022 that will close this issue
@travisnielsen
Copy link
Contributor

Agree that it would be helpful to have an icon for (regular) Power BI. I could add it to #37 and use the same icon provided for Embedded.

@Potherca
Copy link
Member Author

I could add it to #37 and use the same icon provided for Embedded.

@travisnielsen If you could, that would be awesome! 👍

@travisnielsen
Copy link
Contributor

Power BI icon added to the Analytics section. I also moved Power BI Embedded from the Databases section to Analytics.

@Potherca Potherca moved this to Todo in All Projects Jul 3, 2022
@Potherca Potherca moved this from Todo to Backlog in All Projects Jul 3, 2022
@Potherca Potherca moved this from Backlog to In Progress in All Projects Jul 3, 2022
@Potherca Potherca added this to the v2.2.0 milestone Aug 2, 2022
Repository owner moved this from In Progress to Done in All Projects Aug 3, 2022
@Potherca Potherca self-assigned this Aug 3, 2022
@Potherca Potherca unpinned this issue Sep 1, 2022
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

3 participants