Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Latest Azure icons #31

Merged
merged 3 commits into from
Jan 4, 2022
Merged

Conversation

phatcher
Copy link
Contributor

@phatcher phatcher commented Jul 5, 2021

No description provided.

@Potherca Potherca linked an issue Jul 5, 2021 that may be closed by this pull request
10 tasks
@Potherca Potherca added this to the v2.2.0 milestone Jul 5, 2021
@Potherca Potherca mentioned this pull request Jul 29, 2021
phatcher and others added 3 commits August 21, 2021 14:38
Standardize launch settings to be location-neutral and improve script generation tool information
Change manual image naming to use hyphen rather than space
Update data/processing for optional canvas fit
Updated script code to .NET Core 3.1
Add Active Directory icon - plantuml-stdlib#15
Add Azure Lighthouse icon - plantuml-stdlib#27
Add App configuration/properties icon - plantuml-stdlib#18
Add Subnet icon - plantuml-stdlib#14
Add Blockchain icons - plantuml-stdlib#11
Add Cloud Services icon - plantuml-stdlib#25
Add Service Bus topic/queues
Add Bastion and other missing networking icons
Update Digital Twin icon - plantuml-stdlib#24
Update 40+ icons to official images and retire old svgs
Add Mobile and Mobile Engagement icons
Change manual image naming to use hyphen rather than space
@phatcher phatcher force-pushed the feature/iconupdate branch from 312a796 to e46c5be Compare August 21, 2021 14:11
@Potherca Potherca self-requested a review August 24, 2021 09:45
@Potherca Potherca linked an issue Aug 24, 2021 that may be closed by this pull request
@travisnielsen
Copy link
Contributor

Curious to know if there's a timeline for getting this merged.

@Potherca Potherca merged commit 31b82b5 into plantuml-stdlib:master Jan 4, 2022
@Potherca
Copy link
Member

Potherca commented Jan 4, 2022

@travisnielsen Thank you for pointing out that this had stalled!

The original agreement was that (at least) 2 developers should review changes before merging.

As most other original maintainer have a lot on their plate, I am merging this without the extra review.

@phatcher My apologies for making you wait for such a long time. You hard work and dilligence in supporting this project is very much appreciated. Thank you again for your contributions!

This was referenced Jan 4, 2022
@phatcher
Copy link
Contributor Author

phatcher commented Jan 4, 2022

@Potherca Only issue is I think some of the icons are corrupted - and I don't know enough about svg to diagnose what is going on see https://github.com/plantuml-stdlib/Azure-PlantUML/blob/master/AzureSymbols.md

  • AzurePowerBIEmbedded
  • AzureServiceEndpoint
  • AzureSubnet
  • AzureVirtualNetworkPeering

It's probably systemic or down to the original icons but as I said I can't really help much.

Probably should raise this as another issue as it's so isolated

@Potherca
Copy link
Member

Potherca commented Jan 5, 2022

No worries, I'll take a look. Thanks for making the separate ticket! 👍

# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Update all icons to more recent versions Update URL for Azure icons to latest
3 participants