-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Strengthen frontend Biome linting rules to enforce import and Tailwind sorting, naming conventions, etc. #703
Merged
tjementum
merged 11 commits into
main
from
pp-329-enable-biome-to-sort-tailwind-classes-and-typescript-imports
Mar 8, 2025
Merged
Strengthen frontend Biome linting rules to enforce import and Tailwind sorting, naming conventions, etc. #703
tjementum
merged 11 commits into
main
from
pp-329-enable-biome-to-sort-tailwind-classes-and-typescript-imports
Mar 8, 2025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
e3cb214
to
9be0cc7
Compare
435ae44
to
57c1563
Compare
…warnings as errors plus fix errors
57c1563
to
a48c118
Compare
a48c118
to
9a4af22
Compare
Please retry analysis of this Pull-Request directly on SonarQube Cloud |
9a4af22
to
2dec5d0
Compare
2dec5d0
to
a1694b1
Compare
Please retry analysis of this Pull-Request directly on SonarQube Cloud |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary & Motivation
Updated the Biome configuration to enforce sorted imports in TypeScript and
.tsx
files and sorted Tailwind class names. A full solution-wide cleanup has been performed to align with these changes.Biome's linting rules have been expanded to:
{}
) where necessarypackage.json
, as formatting is now handled vialint
Also, a generic cleanup in the frontend, including fixing most Sonar warnings. Including:
React
whereverReact.ReactNode
is used to avoid warningsavatar.png
mf-types
tomodule-federation-types
Downstream projects
package.json
scriptsUpdate the
application/[your-self-contained system]/WebApp/package.json
to apply the new strict linting rules, and remove theformat
script which is now fully covered by thelint
script:Update
application/[your-self-contained system]/WebApp/bootstrap.tsx
to ignore incorrect casing ofReactDOM
:+ // biome-ignore lint/style/useNamingConvention: ReactDOM is a standard library name with consecutive uppercase letters import ReactDOM from "react-dom/client";
Rename the
MFPlugin
toModuleFederationPlugin
inapplication/[your-self-contained system]/WebApp/rsbuild.config.ts
:Update
application/[your-self-contained system]/WebApp/react-env.d.ts
to use the newmodule-federation-types
folder:Since
npm run format
has been removed, the build CLI command will fail if you continue. After making the above changes, please restart the process by running:pp pull-platform-platform-changes --resume
(where pp is your CLI alias).Checklist