Skip to content

Commit

Permalink
remove defaults from the slider input's min / max args (#280)
Browse files Browse the repository at this point in the history
  • Loading branch information
ellthompson authored Jan 18, 2023
1 parent 29d0dab commit 12657ee
Showing 1 changed file with 4 additions and 4 deletions.
8 changes: 4 additions & 4 deletions src/components/SliderInput/index.ts
Original file line number Diff line number Diff line change
Expand Up @@ -15,11 +15,11 @@ const IS_CHROME = /Chrome\//.test(navigator.userAgent);
*/
export interface SliderInputArgs extends ElementArgs, IBindableArgs, IFlexArgs {
/**
* Sets the minimum value that the numeric input field can take. Defaults to 0.
* Sets the minimum value that the numeric input field can take.
*/
min?: number,
/**
* Sets the maximum value that the numeric input field can take. Defaults to 1.
* Sets the maximum value that the numeric input field can take.
*/
max?: number,
/**
Expand Down Expand Up @@ -83,8 +83,8 @@ class SliderInput extends Element implements IBindable, IFocusable {
const numericInput = new NumericInput({
allowNull: args.allowNull,
hideSlider: true,
min: args.min ?? 0,
max: args.max ?? 1,
min: args.min,
max: args.max,
// @ts-ignore
keyChange: args.keyChange,
// @ts-ignore
Expand Down

0 comments on commit 12657ee

Please # to comment.