Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Smooth camera animation #394

Merged
merged 2 commits into from
Jan 30, 2025
Merged

Smooth camera animation #394

merged 2 commits into from
Jan 30, 2025

Conversation

slimbuck
Copy link
Member

@slimbuck slimbuck commented Jan 30, 2025

This PR:

  • adds cubic (hermite) spline interpolation for camera movement from poses
Screen.Recording.2025-01-30.at.09.24.47.mov

Notes:

  • with the new native project format (which stores camera poses) and camera interpolation, we can now:
    • offer the option of exporting animated movies
    • export camera spline to html viewer
    • improve the camera poses panel considerably
      • support multiple camera pose sets
      • transform pose sets with gizmos
      • support basic delete/insert/modify controls
      • display camera poses in the viewport
      • support selection of camera pose from 3d viewport
      • support for various camera input/export formats (especially nerfstudio format cc @simonbethke)
      • approximately another million things

@slimbuck slimbuck added the enhancement New feature label Jan 30, 2025
@slimbuck slimbuck requested a review from a team January 30, 2025 09:31
@slimbuck slimbuck self-assigned this Jan 30, 2025
Copy link
Contributor

@willeastcott willeastcott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great! I do wonder about whether cameras should be keyed on the timeline though. Undecided on that.

@slimbuck
Copy link
Member Author

Ultimately a timeline would be the best. The camera pose panel builds the spline with consistent time steps, but the underlying spline implementation handles arbitrary times. So once we add timeline it should largely still just work.

@slimbuck slimbuck merged commit 3e9a7c9 into playcanvas:main Jan 30, 2025
2 checks passed
@slimbuck slimbuck deleted the pose-dev branch January 30, 2025 10:02
@willeastcott
Copy link
Contributor

Ultimately a timeline would be the best. The camera pose panel builds the spline with consistent time steps, but the underlying spline implementation handles arbitrary times. So once we add timeline it should largely still just work.

Then we can go with this but if there's time, consider squeezing in a very basic upgrade to our 4DGS timeline control. Let's see how things go over the next couple of days.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
enhancement New feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants